http://codereview.chromium.org/6625084/diff/1/src/arm/assembler-arm.h File src/arm/assembler-arm.h (right):
http://codereview.chromium.org/6625084/diff/1/src/arm/assembler-arm.h#newcode994 src/arm/assembler-arm.h:994: const Condition cond = al); The vneg instruction should also be supported by the disassembler (see Decoder::DecodeTypeVFP in disasm-arm.cc). Currently, the disassembler will only print "unknown". Please also add a test in test-disasm-arm.cc. http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-arm.h File src/arm/lithium-arm.h (right): http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-arm.h#newcode1461 src/arm/lithium-arm.h:1461: explicit LDoubleToI(LOperand* value, LOperand* temp1, LOperand* temp2) { explicit is not needed here. http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.cc#newcode2760 src/arm/lithium-codegen-arm.cc:2760: void LCodeGen::EmitECMATruncate(Register result, As fschneider suggested, it would be good to move this code (or parts of it) to a stub and call it from here. http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.cc#newcode2788 src/arm/lithium-codegen-arm.cc:2788: // default 'round to zero' mode. We should measure later, if bit-fiddeling code as used in IntegerConvert in code-stubs-ia32 is actually faster. http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.cc#newcode2817 src/arm/lithium-codegen-arm.cc:2817: const double two_31_value = 2147483648.0; Constants should be formatted as follows: kTwo31Value and kTwo32Value. http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.cc#newcode2846 src/arm/lithium-codegen-arm.cc:2846: // Add or subtrct 2^31 to easily round it toward zero. subtrct -> subtract. http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.cc#newcode2855 src/arm/lithium-codegen-arm.cc:2855: __ vcvt_s32_f64(double_input.low(), double_input); Should this code not use vcvt_u32_f64 as stated in the comment above? http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.h File src/arm/lithium-codegen-arm.h (right): http://codereview.chromium.org/6625084/diff/1/src/arm/lithium-codegen-arm.h#newcode245 src/arm/lithium-codegen-arm.h:245: Label* done); These functions should perhaps be in the macro assembler, because they are not specific for lithium code generation and the macro assembler already contains FP conversion and truncation operations. http://codereview.chromium.org/6625084/diff/1/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/6625084/diff/1/src/arm/simulator-arm.cc#newcode2465 src/arm/simulator-arm.cc:2465: // The Following ARMv7 VFPv instructions are currently supported. Please add the vneg instruction here. http://codereview.chromium.org/6625084/diff/1/src/arm/simulator-arm.cc#newcode2508 src/arm/simulator-arm.cc:2508: double dd_value = - dm_value; - dm_value -> -dm_value (no space). http://codereview.chromium.org/6625084/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
