LGTM
http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc#newcode3670 src/x64/code-stubs-x64.cc:3670: static const int kOffsetToResultValue = 21; Please comment on what instructions these words represent. http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc#newcode3673 src/x64/code-stubs-x64.cc:3673: // None of the flags are supported on X64. This comment seems no longer valid. None -> Some? Args in registers not supported - right? http://codereview.chromium.org/6621071/diff/8/src/x64/code-stubs-x64.cc#newcode3781 src/x64/code-stubs-x64.cc:3781: __ movl(rax, Immediate(0xB8)); // TrueValue is at -9 * kPointerSize. TrueValue -> FalseValue http://codereview.chromium.org/6621071/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
