Reviewers: ,
Message:
It just peppers the output with a lot of failed unlinks w/o this (and it
indeed
does not unlink them).
Description:
[Isolates] Make test.py ignore occasional Windows unlink() failures
Please review this at http://codereview.chromium.org/6660020/
SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/
Affected files:
M tools/test.py
Index: tools/test.py
===================================================================
--- tools/test.py (revision 7111)
+++ tools/test.py (working copy)
@@ -502,12 +502,20 @@
def CheckedUnlink(name):
- try:
- os.unlink(name)
- except OSError, e:
- PrintError("os.unlink() " + str(e))
+ # On Windows, when run with -jN in parallel processes,
+ # OS often fails to unlink the temp file. Not sure why.
+ # Need to retry.
+ # Idea from
https://bugs.webkit.org/attachment.cgi?id=75982&action=prettypatch
+ retry_count = 0
+ while retry_count < 30:
+ try:
+ os.unlink(name)
+ return
+ except OSError, e:
+ retry_count += 1;
+ time.sleep(retry_count * 0.1)
+ PrintError("os.unlink() " + str(e))
-
def Execute(args, context, timeout=None):
(fd_out, outname) = tempfile.mkstemp()
(fd_err, errname) = tempfile.mkstemp()
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
