http://codereview.chromium.org/6685045/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/6685045/diff/1/src/hydrogen.cc#newcode4536 src/hydrogen.cc:4536: instr = new HSub(graph_->GetConstant0(), value); I'm suspicious of this case. Isn't it true that: -(0) = 0-0 = 0+(-0) = +0 ? We should probably have a test that checks the corner cases for unary minus. There is type feedback for the stub in unoptimized code, so it seems better to call HGraphBuilder::BuildBinaryOperation and get our hands on that feedback. http://codereview.chromium.org/6685045/diff/1/src/hydrogen.cc#newcode4539 src/hydrogen.cc:4539: instr = new HSub(value, graph_->GetConstant0()); I'm also suspicious of this: +(-0) = 0-(-0) = 0+0 = +0 http://codereview.chromium.org/6685045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
