Reviewers: Lasse Reichstein, Mads Ager, Kevin Millikin,
Message: Implementing strict mode poison pills for arguments object. Kevin, I hope this doesn't interfere much with your arguments rewrite... Thank you! Martin http://codereview.chromium.org/6698015/diff/1/src/heap.h File src/heap.h (right): http://codereview.chromium.org/6698015/diff/1/src/heap.h#newcode596 src/heap.h:596: The length and callee properties switch places in the in-object representation of arguments. Only length is present always, callee only for non-strict mode arguments. calle for strict mode arguments is an accessor pair hanging off the map. http://codereview.chromium.org/6698015/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6698015/diff/1/src/runtime.cc#newcode4373 src/runtime.cc:4373: // Handle special arguments properties. Runtime_GetArgumentsProperty ... it only appears to be called as a slow path for _Arguments[?] inline call from JS runtime code. This code may not be hit since I couldn't find _Arguments[x] with "callee" as property name. Not sure if caller should be handled here as well since I suspect this code is not used... Description: Implement strict mode arguments caller/callee. BUG= TEST=test/mjsunit/strict-mode.js Please review this at http://codereview.chromium.org/6698015/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/arm/code-stubs-arm.cc M src/arm/codegen-arm.h M src/arm/codegen-arm.cc M src/arm/full-codegen-arm.cc M src/bootstrapper.cc M src/builtins.h M src/builtins.cc M src/code-stubs.h M src/codegen-inl.h M src/codegen.cc M src/contexts.h M src/heap.h M src/heap.cc M src/ia32/code-stubs-ia32.cc M src/ia32/codegen-ia32.h M src/ia32/codegen-ia32.cc M src/ia32/full-codegen-ia32.cc M src/messages.js M src/runtime.cc M src/x64/code-stubs-x64.cc M src/x64/codegen-x64.h M src/x64/codegen-x64.cc M src/x64/full-codegen-x64.cc M test/es5conform/es5conform.status M test/mjsunit/strict-mode.js -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
