LGTM
http://codereview.chromium.org/6677036/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/6677036/diff/1/src/bootstrapper.cc#newcode568 src/bootstrapper.cc:568: On 2011/03/15 03:08:57, Martin Maly wrote:
For some reason this felt cleaner, to freeze first and then install...
I agree. :) http://codereview.chromium.org/6677036/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/6677036/diff/1/src/ia32/code-stubs-ia32.cc#newcode73 src/ia32/code-stubs-ia32.cc:73: ? Context::FUNCTION_MAP_STRICT_INDEX This is part of another change but I think I would prefer the name STRICT_FUNCTION_MAP_INDEX or even (but that is very long) STRICT_MODE_FUNCTION_MAP_INDEX. Similarly for the other strict mode variants of maps. http://codereview.chromium.org/6677036/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
