Reviewers: Mads Ager, Lasse Reichstein,
Message:
Trying again...
Description:
3 patches in this CR to keep things a bit easier to follow.
First patch is straight-up revert of Mads' revert of my original commit
http://code.google.com/p/v8/source/detail?r=7168
Second patch is fix for the Kraken issue. It turns out that V8 temporarily
sets
function prototype as read only while builtins are being processed but later
switches it back to read/write. I only did the first part for strict mode
functions so now I am doing the second half as well.
Third patch is series of renames Mads suggested. I went for the long names.
Given how rarely they are actually used the more descriptive name seemed
better.
As for testing on Kraken ... I tested few of the Kraken tests manually on
command line V8 (thanks, Mads, for the link) but also built Chrome with this
change and ran the web Kraken test to make sure things are alright.
Thank you!
Martin
Please review this at http://codereview.chromium.org/6694044/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/codegen-arm.cc
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/bootstrapper.cc
M src/builtins.h
M src/builtins.cc
M src/contexts.h
M src/factory.h
M src/factory.cc
M src/handles.h
M src/handles.cc
M src/ia32/codegen-ia32.cc
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/messages.js
M src/objects.cc
M src/runtime.cc
M src/x64/codegen-x64.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M test/mjsunit/strict-mode.js
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
