http://codereview.chromium.org/6701003/diff/2001/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right):
http://codereview.chromium.org/6701003/diff/2001/src/x64/lithium-codegen-x64.cc#newcode873 src/x64/lithium-codegen-x64.cc:873: } else if (right_value == 0) { Yes, I noticed too that we bail out even if we don't know if the left-hand side is negative. I decided to keep it for now, under the assumption that if you are multiplying by a constant zero, you are either doing something incredibly stupid or something incredibly clever, but I won't try too hard to save a few bytes. I'll fix it so we don't deoptimize on multiplying a positive value by constant zero in another CL. http://codereview.chromium.org/6701003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
