LGTM with comments addressed.
http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6676060/diff/1/src/arm/lithium-codegen-arm.cc#newcode900 src/arm/lithium-codegen-arm.cc:900: // Compute the quotient. Please extend comment to say that the quotient is also rounded to 32-bit integer value. http://codereview.chromium.org/6676060/diff/1/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/6676060/diff/1/src/arm/macro-assembler-arm.h#newcode829 src/arm/macro-assembler-arm.h:829: void JumpIfNotPowerOfTwoOrZeroAndNeg(Register reg, Please add a separate comment for this function. http://codereview.chromium.org/6676060/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
