LGTM

http://codereview.chromium.org/6713075/diff/3002/src/heap.h
File src/heap.h (right):

http://codereview.chromium.org/6713075/diff/3002/src/heap.h#newcode1788
src/heap.h:1788: ASSERT(object->IsHeapObject());
Do we really want this?

Sometimes it's better to have an early detection of mark stack
corruption.

http://codereview.chromium.org/6713075/diff/3002/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/6713075/diff/3002/src/spaces.h#newcode121
src/spaces.h:121: class MarkBit {
// TODO(gc) ensure all operations inlined and object is exploded by
compiler on all platforms.

http://codereview.chromium.org/6713075/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to