On 2011/03/21 17:16:10, Vitaly Repeshko wrote:
LGTM, thanks!
http://codereview.chromium.org/6712062/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):
http://codereview.chromium.org/6712062/diff/1/src/platform-linux.cc#newcode953
src/platform-linux.cc:953: state = SamplerRegistry::GetState();
*Facepalm*
But please fix it in a slightly different way:
SamplerRegistry::State state;
while ((state = SamplerRegistry::GetState()) !=
SamplerRegistry::HAS_NO_SAMPLERS) { ... }
Right. I missed 'continue' statements. Corrected.
platform-macos.cc also needs to be fixed.
http://codereview.chromium.org/6712062/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
