http://codereview.chromium.org/6685087/diff/1/src/api.cc File src/api.cc (right):
http://codereview.chromium.org/6685087/diff/1/src/api.cc#newcode2395 src/api.cc:2395: // propagate outside. On 2011/03/21 10:33:22, Mads Ager wrote:
propagate -> to propagate?
Done. http://codereview.chromium.org/6685087/diff/1/src/messages.cc File src/messages.cc (right): http://codereview.chromium.org/6685087/diff/1/src/messages.cc#newcode115 src/messages.cc:115: static int in_process = false; On 2011/03/21 10:33:22, Mads Ager wrote:
This will not work with isolates. You need this to be store in the
isolate
somewhere. Also, it will probably not work with Lockers either. There
might be a
thread switch while reporting messages with on thread.
I think this should be added to the archived thread state that is part
of the
isolate (make it part of Top like the rest of the exception state).
Done. http://codereview.chromium.org/6685087/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
