On Mon, Mar 21, 2011 at 10:29 PM, Dmitry Lomov <[email protected]> wrote: > Oh, wait dont land yet - I'll scrub v8::String a bit more and send a bigger > patch.
Sure. Ping me when it's ready for another look then. -- Vitaly > On Mon, Mar 21, 2011 at 12:26 PM, <[email protected]> wrote: >> >> LGTM. Yes, this seems to be right approach. >> >> I'll land >> >> >> Thanks, >> Vitaly >> >> >> http://codereview.chromium.org/6716004/diff/1/src/api.cc >> File src/api.cc (right): >> >> http://codereview.chromium.org/6716004/diff/1/src/api.cc#newcode4054 >> src/api.cc:4054: i::Isolate* isolate = (*obj)->GetIsolate(); >> obj->GetIsolate() should also work. >> >> http://codereview.chromium.org/6716004/ > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
