LGTM, feel free to use or discard my comment below. Cheers! Martin
http://codereview.chromium.org/6712059/diff/1/test/mjsunit/strict-mode.js File test/mjsunit/strict-mode.js (right): http://codereview.chromium.org/6712059/diff/1/test/mjsunit/strict-mode.js#newcode987 test/mjsunit/strict-mode.js:987: assertEquals(pill.value, undefined); This is alright. We could also have: assertThrows(function() { 'use strict'; pill.property = "value"; }, TypeError); either instead or in addition to your check. I am fine with either option. The paranoid me would go for both :) http://codereview.chromium.org/6712059/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
