LGTM

http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc
File test/cctest/test-reloc-info.cc (right):

http://codereview.chromium.org/6719022/diff/1/test/cctest/test-reloc-info.cc#newcode45
test/cctest/test-reloc-info.cc:45: const int code_size = 10 << 10;
Odd way to write a constant. Why not just 10 * KB, or (if KB isn't
available here) 10240. Or 100 * 100, to match what is being done below.

http://codereview.chromium.org/6719022/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to