I can't get rid of movq(Register, ExternalReference) yet, since I didn't
change
codegen-x64.cc (soon to be dead anyway) and I probably left a few uses in
debug-only code as well.
However, I do think it's a good idea for a future patch.
http://codereview.chromium.org/6716018/diff/1/src/x64/deoptimizer-x64.cc
File src/x64/deoptimizer-x64.cc (left):
http://codereview.chromium.org/6716018/diff/1/src/x64/deoptimizer-x64.cc#oldcode760
src/x64/deoptimizer-x64.cc:760: ExternalReference roots_address =
ExternalReference::roots_address();
I don't see how. It's a local variable that isn't used anywhere.
I think it's just a leftover from when InitializeRootRegister was
introduced.
http://codereview.chromium.org/6716018/diff/1/src/x64/regexp-macro-assembler-x64.cc
File src/x64/regexp-macro-assembler-x64.cc (right):
http://codereview.chromium.org/6716018/diff/1/src/x64/regexp-macro-assembler-x64.cc#newcode67
src/x64/regexp-macro-assembler-x64.cc:67: * kRootRegister) are not
initialized during RegExp code.
Except that they are not free either (since we don't save them and they
are callee-save).
Rewording.
http://codereview.chromium.org/6716018/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
