http://codereview.chromium.org/6717018/diff/1/src/builtins.cc
File src/builtins.cc (right):

http://codereview.chromium.org/6717018/diff/1/src/builtins.cc#newcode1689
src/builtins.cc:1689: return
Handle<Code>(isolate->builtins()->builtin(name), isolate);
I think we can reuse builtin address to avoid allocating an extra handle
slot.

http://codereview.chromium.org/6717018/diff/1/src/builtins.h
File src/builtins.h (right):

http://codereview.chromium.org/6717018/diff/1/src/builtins.h#newcode297
src/builtins.h:297: static Handle<Code> builtin(Name name, Isolate*
isolate);
Why you don't want to make this an instance method? "builtin_handle"? Or
maybe rename "Code* builtin(Name name)" to "Code* buildin_code(Name
name)" and use "builtin" here.

http://codereview.chromium.org/6717018/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to