Revision: 7307
Author: [email protected]
Date: Tue Mar 22 08:16:29 2011
Log: Remove TLS fetches in v8::String API implementation.
Patch by Dmitry Lomov.
Original review: http://codereview.chromium.org/6716004/
TBR=ager
Review URL: http://codereview.chromium.org/6716023
http://code.google.com/p/v8/source/detail?r=7307
Modified:
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/src/api.cc Fri Mar 18 13:35:07 2011
+++ /branches/bleeding_edge/src/api.cc Tue Mar 22 08:16:29 2011
@@ -3914,14 +3914,14 @@
Local<String> v8::String::Concat(Handle<String> left, Handle<String>
right) {
- i::Isolate* isolate = i::Isolate::Current();
- EnsureInitializedForIsolate(isolate, "v8::String::New()");
- LOG_API(isolate, "String::New(char)");
- ENTER_V8;
i::Handle<i::String> left_string = Utils::OpenHandle(*left);
+ i::Isolate* isolate = left_string->GetIsolate();
+ EnsureInitializedForIsolate(isolate, "v8::String::Concat()");
+ LOG_API(isolate, "String::Concat()");
+ ENTER_V8;
i::Handle<i::String> right_string = Utils::OpenHandle(*right);
- i::Handle<i::String> result = FACTORY->NewConsString(left_string,
- right_string);
+ i::Handle<i::String> result =
isolate->factory()->NewConsString(left_string,
+
right_string);
return Utils::ToLocal(result);
}
@@ -3933,7 +3933,8 @@
ENTER_V8;
if (length == -1) length = i::StrLength(data);
i::Handle<i::String> result =
- FACTORY->NewStringFromUtf8(i::Vector<const char>(data, length));
+ isolate->factory()->NewStringFromUtf8(
+ i::Vector<const char>(data, length));
result->MarkAsUndetectable();
return Utils::ToLocal(result);
}
@@ -4003,11 +4004,11 @@
bool v8::String::MakeExternal(v8::String::ExternalStringResource*
resource) {
- i::Isolate* isolate = i::Isolate::Current();
+ i::Handle<i::String> obj = Utils::OpenHandle(this);
+ i::Isolate* isolate = obj->GetIsolate();
if (IsDeadCheck(isolate, "v8::String::MakeExternal()")) return false;
if (this->IsExternal()) return false; // Already an external string.
ENTER_V8;
- i::Handle<i::String> obj = Utils::OpenHandle(this);
if (isolate->string_tracker()->IsFreshUnusedString(obj)) {
return false;
}
@@ -4033,11 +4034,11 @@
bool v8::String::MakeExternal(
v8::String::ExternalAsciiStringResource* resource) {
- i::Isolate* isolate = i::Isolate::Current();
+ i::Handle<i::String> obj = Utils::OpenHandle(this);
+ i::Isolate* isolate = obj->GetIsolate();
if (IsDeadCheck(isolate, "v8::String::MakeExternal()")) return false;
if (this->IsExternal()) return false; // Already an external string.
ENTER_V8;
- i::Handle<i::String> obj = Utils::OpenHandle(this);
if (isolate->string_tracker()->IsFreshUnusedString(obj)) {
return false;
}
@@ -4050,9 +4051,9 @@
bool v8::String::CanMakeExternal() {
- i::Isolate* isolate = i::Isolate::Current();
- if (IsDeadCheck(isolate, "v8::String::CanMakeExternal()")) return false;
i::Handle<i::String> obj = Utils::OpenHandle(this);
+ i::Isolate* isolate = obj->GetIsolate();
+ if (IsDeadCheck(isolate, "v8::String::CanMakeExternal()")) return false;
if (isolate->string_tracker()->IsFreshUnusedString(obj)) {
return false;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
