Kevin, thanks for your comments!
-- Vitaly http://codereview.chromium.org/6707001/diff/4001/src/small-pointer-list.h File src/small-pointer-list.h (right): http://codereview.chromium.org/6707001/diff/4001/src/small-pointer-list.h#newcode62 src/small-pointer-list.h:62: PointerList* list = new PointerList(2); On 2011/03/23 07:38:44, Kevin Millikin wrote:
We should count the lengths of use lists that are >= 2. This backing
store will
be resized as soon as we add a another use.
If this is frequent, we should avoid the doubling and wasted 2-element
list and
preallocate it a bit bigger.
When compiling the V8 benchmark the number of values with 2 uses is approximately equal to the number of values with strictly more than 2 uses. So I think it makes sense to keep 2 here. http://codereview.chromium.org/6707001/diff/4001/src/small-pointer-list.h#newcode86 src/small-pointer-list.h:86: void RemoveElement(T* pointer) { On 2011/03/23 07:38:44, Kevin Millikin wrote:
Maybe a short comment that the intended semantics is to remove if
present (like
List::RemoveElement).
Done. http://codereview.chromium.org/6707001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
