LGTM Committed: http://code.google.com/p/v8/source/detail?r=7358
http://codereview.chromium.org/6730029/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6730029/diff/1/src/arm/lithium-codegen-arm.cc#newcode1178 src/arm/lithium-codegen-arm.cc:1178: bool can_overflow = instr->hydrogen()->CheckFlag(HValue::kCanOverflow); On 2011/03/25 00:23:09, Rodolph Perfetta wrote:
On 2011/03/24 20:32:24, Søren Gjesse wrote: > Can't we just use SetCC always?
We could, but on modern cores, setting the flags when not needed
introduces a
dependency which tend to reduce the core efficiency. Admittedly the
impact for
one instruction is going to be very small. If you want I'll revert
that. No, I am fine with that - I just wanted to know the reason. http://codereview.chromium.org/6730029/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
