Reviewers: Vitaly Repeshko,
http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc File src/platform-freebsd.cc (right): http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode639 src/platform-freebsd.cc:639: const pthread *vm_tid() const { return vm_tid_; } On 2011/03/28 12:02:30, Vitaly Repeshko wrote:
I think this should return "pthread_t" (no const).
Done. http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode642 src/platform-freebsd.cc:642: const pthread *vm_tid_; On 2011/03/28 12:02:30, Vitaly Repeshko wrote:
pthread_t
Done. http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode692 src/platform-freebsd.cc:692: thread_id_(pthread_self()), On 2011/03/28 12:02:30, Vitaly Repeshko wrote:
Should be unused -- see below.
Done. http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode783 src/platform-freebsd.cc:783: void SendProfilingSignal(const pthread *tid) { On 2011/03/28 12:02:30, Vitaly Repeshko wrote:
pthread_t
Done. http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode785 src/platform-freebsd.cc:785: pthread_kill(thread_id_, SIGPROF); On 2011/03/28 12:02:30, Vitaly Repeshko wrote:
Use the thread id parameter here.
Done. Description: Build and pass all tests on FreeBSD. Please review this at http://codereview.chromium.org/6726050/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/platform-freebsd.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
