Reviewers: Søren Gjesse,

Message:
Baby stems in gyp. Turns out currently d8 console when built via gyp doesn't run
because of inconsistent #defines. This CL fixes that.

Next will be reconciling build flags for xcode builds which could hopefully lead
to reducing the warning number (currently 1600+) and ultimate removal of
v8.xcodeproj.

Main problem I foresee here is that there are multiple gyp-generated project
files and one has to regenerate them for different platforms...

Thank you!
Martin

Description:
Fix gyp files for d8 console. Include build/gyp in .gitignore.


BUG=
TEST=


Please review this at http://codereview.chromium.org/6765006/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M .gitignore
  M src/d8.gyp


Index: .gitignore
diff --git a/.gitignore b/.gitignore
index c6b604775198ee3cbecc387a14dd98f6daa10738..af1b0d7381669371b749c27d0f2bf6cfec96ea6a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -19,6 +19,7 @@ d8
 d8_g
 shell
 shell_g
+/build/gyp
 /obj/
 /test/es5conform/data/
 /test/mozilla/data/
Index: src/d8.gyp
diff --git a/src/d8.gyp b/src/d8.gyp
index 3283e38ae33b439f04f67abc1c5ecadc548ac449..901fd6515ef8c5cded882d9738e1f0329758934a 100644
--- a/src/d8.gyp
+++ b/src/d8.gyp
@@ -38,7 +38,10 @@
         '../src',
       ],
       'defines': [
+        'ENABLE_LOGGING_AND_PROFILING',
         'ENABLE_DEBUGGER_SUPPORT',
+        'ENABLE_VMSTATE_TRACKING',
+        'V8_FAST_TLS',
       ],
       'sources': [
         'd8.cc',


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to