Reviewers: Vitaly Repeshko, Dmitry Titov,
Message:
When building v8 shell with -Wall compiler reports:
In constructor ‘SourceGroup::IsolateThread::IsolateThread(SourceGroup*)’:
‘SourceGroup::IsolateThread::group_’ will be initialized after
base ‘v8::internal::Thread’ when initialized here
Changing the initialization order addresses this. "Run" is not (and should
not
be) called from the constructor so the change is safe.
Thanks!
Martin
Description:
Fix xcode build warning in shell.cc
(out of order initialization).
BUG=
TEST=
Please review this at http://codereview.chromium.org/6772021/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M samples/shell.cc
Index: samples/shell.cc
diff --git a/samples/shell.cc b/samples/shell.cc
index
47de84683566a8c63cb77a645c5ba8671913a6e8..0710d4643aa3a4845714f6e0259a9198ff5e81f0
100644
--- a/samples/shell.cc
+++ b/samples/shell.cc
@@ -157,7 +157,7 @@ class SourceGroup {
class IsolateThread : public v8::internal::Thread {
public:
explicit IsolateThread(SourceGroup* group)
- : group_(group), v8::internal::Thread(NULL, GetThreadOptions()) {}
+ : v8::internal::Thread(NULL, GetThreadOptions()), group_(group) {}
virtual void Run() {
group_->ExecuteInThread();
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
