Drive by comments.
Thanks, Vitaly http://codereview.chromium.org/6777007/diff/1/src/platform-posix.cc File src/platform-posix.cc (right): http://codereview.chromium.org/6777007/diff/1/src/platform-posix.cc#newcode215 src/platform-posix.cc:215: void OS::MemCopy(void* dest, const void* src, size_t size) { Why does this have to be in platform files? It'd be nice to avoid repeating it. http://codereview.chromium.org/6777007/diff/1/src/platform-posix.cc#newcode220 src/platform-posix.cc:220: memcopy_function = CreateMemCopyFunction(); You need a memory barrier between function creation and storing it to the global pointer to make double-checked locking safe. Use MemoryBarrier or Release_Store from atomicops. http://codereview.chromium.org/6777007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
