LGTM
http://codereview.chromium.org/6670115/diff/1003/src/ic.cc File src/ic.cc (right): http://codereview.chromium.org/6670115/diff/1003/src/ic.cc#newcode1146 src/ic.cc:1146: // Check for values that can be converted into a symbol. Could you file a bug report stating that this is put in because Kraken 1.1 is not released in the web runner. Kraken 1.0 accesses undefined and NaN in arrays a lot and this speeds it up. We have put it in so people do not make wrong conclusions based on broken benchmarks. Once the web runner is updated to Kraken 1.1 which does correct array accesses we should get rid of this again. http://codereview.chromium.org/6670115/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
