LGTM.
http://codereview.chromium.org/6771045/diff/2001/src/compiler.cc File src/compiler.cc (right): http://codereview.chromium.org/6771045/diff/2001/src/compiler.cc#newcode700 src/compiler.cc:700: if (FLAG_lazy && allow_lazy) { I think this whole conditional could be simpler: if (FLAG_lazy && allow_lazy) { Handle<Code> code = info.isolate()->builtins()->LazyCompile(); info.SetCode(code); } else if ((V8::UseCrankshaft() && MakeCrankshaftCode(&info)) || (!V8::UseCrankshaft() && FullCodeGenerator::MakeCode(&info))) { ASSERT(!info.code().is_null()); scope_info = SerializedScopeInfo::Create(info.scope()); } else { return Handle<SharedFunctionInfo>::null(); } http://codereview.chromium.org/6771045/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
