LGTM.
http://codereview.chromium.org/6758007/diff/11008/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right): http://codereview.chromium.org/6758007/diff/11008/src/arm/lithium-arm.cc#newcode1727 src/arm/lithium-arm.cc:1727: LLoadGlobalCell* result = new LLoadGlobalCell(); Should be enough to write: new LLoadGlobalCell; http://codereview.chromium.org/6758007/diff/11008/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6758007/diff/11008/src/arm/lithium-codegen-arm.cc#newcode2183 src/arm/lithium-codegen-arm.cc:2183: RelocInfo::Mode mode = instr->for_typeof() ? RelocInfo::CODE_TARGET : For consistency maybe align like ? RelocInfo::CODE_TARGET : RelocInfo::CODE_TARGET_CONTEXT; http://codereview.chromium.org/6758007/diff/11008/src/ast.cc File src/ast.cc (right): http://codereview.chromium.org/6758007/diff/11008/src/ast.cc#newcode96 src/ast.cc:96: // names must be canonicalized for fast equality checks -->Names must be canonicalized for fast equality checks. http://codereview.chromium.org/6758007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
