Reviewers: Vitaly Repeshko, Description: Simplify isolates access during stack iteration (WAS: Move SafeStackFrameIterator::active_count_...)
While trying to fix Mac and Windows versions for this change: http://codereview.chromium.org/6771047/, I figured out, that we already store an isolate in StackFrameIterator, so we can use it in frame objects, instead of requiring it from caller. I've changed iterators usage to the following scheme: whenever a caller maintains an isolate pointer, it just passes it to stack iterator, and no more worries about passing it to frame content accessors. If a caller uses current isolate, it can omit passing it to iterator, in this case, an iterator will use the current isolate, too. There was a special case with LiveEdit, which creates detached copies of frame objects. [email protected] BUG=none TEST=none Please review this at http://codereview.chromium.org/6794019/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/accessors.cc M src/compiler.cc M src/cpu-profiler.cc M src/debug.h M src/debug.cc M src/execution.cc M src/frames-inl.h M src/frames.h M src/frames.cc M src/isolate.h M src/liveedit.cc M src/log.cc M src/mark-compact.cc M src/runtime-profiler.cc M src/runtime.cc M src/top.cc M src/v8threads.h M test/cctest/test-accessors.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
