http://codereview.chromium.org/6794019/diff/2002/src/frames-inl.h
File src/frames-inl.h (right):
http://codereview.chromium.org/6794019/diff/2002/src/frames-inl.h#newcode97
src/frames-inl.h:97: inline Isolate* StackFrame::isolate() const {
On 2011/04/04 20:37:08, Vitaly Repeshko wrote:
I'm not convinced we need this tricky stuff. Usually we only create
one frame
object per type and reuse them while a stack iterator is active, and
we don't
care that much about the memory usage in the live edit case. Please
use an
explicit isolate field.
I agree. I was in a premature optimization mood. Split into two fields.
http://codereview.chromium.org/6794019/diff/2002/src/frames.cc
File src/frames.cc (right):
http://codereview.chromium.org/6794019/diff/2002/src/frames.cc#newcode425
src/frames.cc:425: if (SafeStackFrameIterator::is_active(isolate))
On 2011/04/04 20:37:08, Vitaly Repeshko wrote:
nit: Format one a single line if fits, use {} otherwise.
Done.
http://codereview.chromium.org/6794019/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
