LGTM. Thanks for refactoring of heap number materialization!
http://codereview.chromium.org/6677164/diff/1/src/frames.h File src/frames.h (right): http://codereview.chromium.org/6677164/diff/1/src/frames.h#newcode571 src/frames.h:571: return Smi::cast(GetExpression(0))->value(); Too much indentation. http://codereview.chromium.org/6677164/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6677164/diff/1/src/runtime.cc#newcode7331 src/runtime.cc:7331: for (int i = 0; i < frames; i++) { That's a little confusing to get to the bottom frame of the deopt. Can you just write e.g.: for (int i = 0; i < frames - 1; i++) it.Advance(); http://codereview.chromium.org/6677164/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
