Ah, just noticed Martin submitted a fix already. Please ignore this code review.
-- Vitaly On Wed, Apr 6, 2011 at 3:52 PM, <[email protected]> wrote: > Reviewers: Martin Maly, > > Description: > Fix non-ia32 builds. > > [email protected] > > Please review this at http://codereview.chromium.org/6805025/ > > Affected files: > M src/arm/lithium-codegen-arm.h > M src/arm/simulator-arm.cc > M src/x64/lithium-codegen-x64.h > > > Index: src/arm/lithium-codegen-arm.h > diff --git a/src/arm/lithium-codegen-arm.h b/src/arm/lithium-codegen-arm.h > index > caa85d27489fc759565dce3a73b7c26bca33e75c..cfde7a83287363af324cd52d0030eaef66931455 > 100644 > --- a/src/arm/lithium-codegen-arm.h > +++ b/src/arm/lithium-codegen-arm.h > @@ -137,7 +137,7 @@ class LCodeGen BASE_EMBEDDED { > bool is_aborted() const { return status_ == ABORTED; } > > int strict_mode_flag() const { > - return info()->is_strict() ? kStrictMode : kNonStrictMode; > + return info()->is_strict_mode() ? kStrictMode : kNonStrictMode; > } > > LChunk* chunk() const { return chunk_; } > Index: src/arm/simulator-arm.cc > diff --git a/src/arm/simulator-arm.cc b/src/arm/simulator-arm.cc > index > 7174088ced2f04673a9a33cf12b428e7fc14b17a..3ab23e20b9e05559a901c28764c68908d8850368 > 100644 > --- a/src/arm/simulator-arm.cc > +++ b/src/arm/simulator-arm.cc > @@ -1618,7 +1618,7 @@ void Simulator::HandleVList(Instruction* instr) { > address += 2; > } > } > - ASSERT_EQ(((intptr_t)address) - operand_size, end_address); > + ASSERT(reinterpret_cast<intptr_t>(address) - operand_size == > end_address); > } > > > Index: src/x64/lithium-codegen-x64.h > diff --git a/src/x64/lithium-codegen-x64.h b/src/x64/lithium-codegen-x64.h > index > f44fdb95107f4e7881a9104caf6fc35f8ae87cf6..70ff63c4334e209e5e9c5f3370f32ed46542c68b > 100644 > --- a/src/x64/lithium-codegen-x64.h > +++ b/src/x64/lithium-codegen-x64.h > @@ -124,7 +124,7 @@ class LCodeGen BASE_EMBEDDED { > bool is_aborted() const { return status_ == ABORTED; } > > int strict_mode_flag() const { > - return info()->is_strict() ? kStrictMode : kNonStrictMode; > + return info()->is_strict_mode() ? kStrictMode : kNonStrictMode; > } > > LChunk* chunk() const { return chunk_; } > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
