LGTM
http://codereview.chromium.org/6812002/diff/1/tools/gcmole/Makefile File tools/gcmole/Makefile (right): http://codereview.chromium.org/6812002/diff/1/tools/gcmole/Makefile#newcode34 tools/gcmole/Makefile:34: g++ -I$(LLVM_INCLUDE) -I$(CLANG_INCLUDE) -I. -D_DEBUG -D_GNU_SOURCE -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -O3 -fomit-frame-pointer -fno-exceptions -fno-rtti -fPIC -Woverloaded-virtual -Wcast-qual -fno-strict-aliasing -pedantic -Wno-long-long -Wall -W -Wno-unused-parameter -Wwrite-strings -shared -o libgcmole.so gcmole.cc Break up this long line? http://codereview.chromium.org/6812002/diff/1/tools/gcmole/README File tools/gcmole/README (right): http://codereview.chromium.org/6812002/diff/1/tools/gcmole/README#newcode8 tools/gcmole/README:8: Handle<Object> Foo(); // assume Foo can trigger a GC. Start comment with uppercase - even in README :-) http://codereview.chromium.org/6812002/diff/1/tools/gcmole/README#newcode20 tools/gcmole/README:20: PREREQUISITES ------------------------------------------------------------------- Long line (few more below). http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.cc File tools/gcmole/gcmole.cc (right): http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.cc#newcode213 tools/gcmole/gcmole.cc:213: if (decl->getTemplatedDecl()->getDeclName() == handleDeclName) return true; Long line. http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.lua File tools/gcmole/gcmole.lua (right): http://codereview.chromium.org/6812002/diff/1/tools/gcmole/gcmole.lua#newcode1 tools/gcmole/gcmole.lua:1: -- Copyright 2011 the V8 project authors. All rights reserved. I don't have the Lua stule quide at hand but it would probably say no long lines (and that you should use Python :-) ). http://codereview.chromium.org/6812002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
