Yes - sounds good - I shot for replacement of ThreadHandle as it was used
before, but value class sounds good.
On 2011/04/08 01:34:38, Vitaly Repeshko wrote:
Dmitry,
Thanks a lot for working on cleaning this up!
I've got a few high-level comments.
I don't really see the value in having both ThreadRef and ThreadId. To
make
things simple could just have some purely static class with kInvalidId and
Current(), or we could make ThreadId a value class (using default copy
ctor
and
operator=) with an interface like:
class ThreadId {
public:
static ThreadId Current();
static ThreadId Invalid();
static ThreadId FromInteger(int); // Is this really needed?
bool Equals(const ThreadId& other);
int ToInteger(); // ?
};
We avoid using the STL. We have our own List class that has std::vector
functionality.
-- Vitaly
http://codereview.chromium.org/6816038/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
