LGTM
http://codereview.chromium.org/6826026/diff/1/src/runtime-profiler.cc File src/runtime-profiler.cc (right): http://codereview.chromium.org/6826026/diff/1/src/runtime-profiler.cc#newcode135 src/runtime-profiler.cc:135: state_counts_[IN_NON_JS_STATE] = kStateWindowSize; Wild idea: when going idle we stop profiler. Why don't we reset it's state when we later restart it? We should experiment with this. http://codereview.chromium.org/6826026/diff/1/src/runtime-profiler.cc#newcode349 src/runtime-profiler.cc:349: state_window_ticks_ = Min(kStateWindowSize, state_window_ticks_ + 1); Our RuntimeProfiler is full of magic and very hard to grok. Lets start adding comments. For example here you can mention that when we start profiling we don't have enough ticks for full window (kStateWindowSize) so to calculate proper ratio we have to use smaller window size equal to amount of ticks we got. http://codereview.chromium.org/6826026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
