LGTM
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-max.js File test/mjsunit/compiler/regress-max.js (right): http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-max.js#newcode34 test/mjsunit/compiler/regress-max.js:34: %OptimizeFunctionOnNextCall(Math.max); On 2011/04/11 12:55:51, jkummerow wrote:
On 2011/04/11 11:06:38, Mads Ager wrote: > This should get inlined if you just optimize f I think.
No: "Did not inline max called from f (target not inlineable).", and
it doesn't
get optimized either without the explicit statement. Want me to remove %OptimizeFunctionOnNextCall(f); instead? I guess
that's not
really required for this test.
I agree with you. What should matter here is that Math.max gets optimize. Introducing f just to give Math.max a shorter name seems unnecessary. Replace all calls to f with calls to Math.max, optimize that and check the results? http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-stacktrace-methods.js File test/mjsunit/compiler/regress-stacktrace-methods.js (right): http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-stacktrace-methods.js#newcode48 test/mjsunit/compiler/regress-stacktrace-methods.js:48: %OptimizeFunctionOnNextCall(Hest.prototype.three); On 2011/04/11 12:55:51, jkummerow wrote:
On 2011/04/11 11:06:38, Mads Ager wrote: > Same here.
Hest.prototype.three can't be inlined (because it throws), and doesn't
get
optimized unless explicitly requested. (Note that I don't request optimization of Svin.prototype.two, because
that
method does get inlined.)
Sounds good. Thanks. http://codereview.chromium.org/6821009/diff/1/test/mjsunit/regress/regress-1106.js File test/mjsunit/regress/regress-1106.js (right): http://codereview.chromium.org/6821009/diff/1/test/mjsunit/regress/regress-1106.js#newcode56 test/mjsunit/regress/regress-1106.js:56: %OptimizeFunctionOnNextCall(x.gee); On 2011/04/11 12:55:51, jkummerow wrote:
On 2011/04/11 11:06:38, Mads Ager wrote: > Shouldn't be necessary. Should be inlined.
Not according to --trace-inlining. I therefore left the line in there.
For this test it doesn't matter whether or not gee is optimized. I'd remove the call in this case. http://codereview.chromium.org/6821009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
