I have checked and currently there is no way to tell which vfp version is specified using gcc defines.
so LGTM. On 11 April 2011 15:10, <[email protected]> wrote: > > http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc > File src/arm/assembler-arm.cc (right): > > > http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#newcode63 > src/arm/assembler-arm.cc:63: #if defined(__VFP_FP__) && > !defined(__SOFTFP__) > On 2011/04/11 12:48:55, Rodolph Perfetta wrote: > >> This would be true for VFPv2 too. >> > > I see, but that was what we had before. I can't seem to find any way to > see from gcc to distinguish. > > > > http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#newcode66 > src/arm/assembler-arm.cc:66: #ifdef CAN_USE_VFP_INSTRUCTIONS > On 2011/04/11 12:48:55, Rodolph Perfetta wrote: > >> I can't find where CAN_USE_VFP_INSTRUCTIONS is defined. >> > > This is defined in the SConstruct file when compiling for Android (maybe > the gcc used for compiling for Android did not define __VFP_FP__). We > could consider removing it, as the SCons based Android build is broken, > and the Android repository has a v8_shell target now. > > > http://codereview.chromium.org/6825037/ > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
