LGTM, but consider guarding against repeated ObjectGroup::Dispose invocations in debug mode (maybe this also applies to other Dispose methods). Feel free to *not* do this as part of this CL.
On Tue, Apr 12, 2011 at 6:51 AM, <[email protected]> wrote: > Reviewers: Mads Ager, > > Description: > Fix retained object info leak. > > Please review this at http://codereview.chromium.org/6813101/ > > Affected files: > M src/global-handles.h > > > Index: src/global-handles.h > diff --git a/src/global-handles.h b/src/global-handles.h > index > 3b6b7b3a7e28c783bab14dc2f463bd72321862bc..9c31d0302d4a877f1fc0bbde8820de3ddd7660e0 > 100644 > --- a/src/global-handles.h > +++ b/src/global-handles.h > @@ -57,6 +57,7 @@ class ObjectGroup { > } > > void Dispose() { > + if (info_ != NULL) info->Dispose(); > free(this); > } > > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
