LGTM. On Tue, Apr 12, 2011 at 7:51 AM, <[email protected]> wrote: > Reviewers: Kasper Lund, > > Description: > Merge r7578 "Fix retained object info leak." to trunk > > Please review this at http://codereview.chromium.org/6813104/ > > SVN Base: http://v8.googlecode.com/svn/trunk/ > > Affected files: > M src/global-handles.h > M src/version.cc > > > Index: src/global-handles.h > =================================================================== > --- src/global-handles.h (revision 7578) > +++ src/global-handles.h (working copy) > @@ -28,6 +28,8 @@ > #ifndef V8_GLOBAL_HANDLES_H_ > #define V8_GLOBAL_HANDLES_H_ > > +#include "../include/v8-profiler.h" > + > #include "list-inl.h" > > namespace v8 { > @@ -57,6 +59,7 @@ > } > > void Dispose() { > + if (info_ != NULL) info_->Dispose(); > free(this); > } > > Index: src/version.cc > =================================================================== > --- src/version.cc (revision 7578) > +++ src/version.cc (working copy) > @@ -35,7 +35,7 @@ > #define MAJOR_VERSION 3 > #define MINOR_VERSION 2 > #define BUILD_NUMBER 9 > -#define PATCH_LEVEL 0 > +#define PATCH_LEVEL 1 > // Use 1 for candidates and 0 otherwise. > // (Boolean macro values are not supported by all preprocessors.) > #define IS_CANDIDATE_VERSION 0 > > >
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
