LGTM, unless you agree that there is a flaw in DeepEquals for arrays
containing
named properties.
http://codereview.chromium.org/6835021/diff/1/test/mjsunit/math-floor.js
File test/mjsunit/math-floor.js (right):
http://codereview.chromium.org/6835021/diff/1/test/mjsunit/math-floor.js#newcode36
test/mjsunit/math-floor.js:36: assertEquals(expect, test(input));
What about the fact that -0 and +0 compare equal? Don't you need to
compare 1/x and 1/y?
http://codereview.chromium.org/6835021/diff/1/test/mjsunit/mjsunit.js
File test/mjsunit/mjsunit.js (right):
http://codereview.chromium.org/6835021/diff/1/test/mjsunit/mjsunit.js#newcode66
test/mjsunit/mjsunit.js:66: var clazz = classOf(value);
object_class? Better than a misspelling.
http://codereview.chromium.org/6835021/diff/1/test/mjsunit/mjsunit.js#newcode152
test/mjsunit/mjsunit.js:152: return false;
What about if a is an Object and b is an Array?
{0:"foo", 1:"bar} and ["foo", "bar"] - OK, I see length would have to be
a non-enumerable property on the object for it to happen. Could this
happen?
What about arrays with named properties - the named properties are not
checked.
http://codereview.chromium.org/6835021/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
