On 2011/04/19 12:20:30, Kevin Millikin wrote:
LGTM.
http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h
File src/arm/lithium-arm.h (right):
http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h#newcode169
src/arm/lithium-arm.h:169: virtual Opcode opcode() const { return
LInstruction::k##type; } \
Thank you.
http://codereview.chromium.org/6877036/diff/3002/src/arm/lithium-arm.h#newcode1109
src/arm/lithium-arm.h:1109: virtual Opcode opcode() const { return
LInstruction::kArithmeticD; }
Maybe add a comment here and below that DECLARE_CONCRETE_INSTRUCTION
doesn't
work because the mnemonic depends on the op?
I'll replace these aggregate instructions pretty soon. They don't seem to
buy us
much.
http://codereview.chromium.org/6877036/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
