LGTM. I like it, it really cleans up the change insertion code.
http://codereview.chromium.org/6881044/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/6881044/diff/1/src/hydrogen-instructions.h#newcode670 src/hydrogen-instructions.h:670: HUseListNode* RemoveUse(HValue* value, int index); How about wrapping HValue* and int in a HUse struct/class? http://codereview.chromium.org/6881044/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
