Thanks for fixing it!

Alexandre


On Thu, Apr 21, 2011 at 10:54 AM, Jakob Kummerow <[email protected]>wrote:

>
> On Thu, Apr 21, 2011 at 11:50 AM, Alexandre Rames <
> [email protected]> wrote:
>
>> Hello,
>>
>> This commit breaks compilation on ARM in debug mode:
>
>
> I'm aware of the breakage and will commit a fix in a couple of minutes; I'm
> still waiting on git-svn because my checkout somehow got confused about
> remote branches and I figured cloning it anew would be faster than figuring
> out what went wrong.
>
>
>
>> It looks like one line was left by mistake.
>>
>> Index: src/arm/code-stubs-arm.cc
>> ===================================================================
>> --- src/arm/code-stubs-arm.cc (revision 7675)
>> +++ src/arm/code-stubs-arm.cc (working copy)
>> @@ -529,8 +529,6 @@
>>                                               Register dst2,
>>                                               Register scratch2,
>>                                               SwVfpRegister
>> single_scratch) {
>> -  ASSERT(!smi_scratch.is(scratch2));
>> -
>>    Label done;
>>
>>    if (CpuFeatures::IsSupported(VFP3)) {
>>
>>
> The proper fix is actually s/smi_scratch/int_scratch/.
>
>

-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to