LGTM with comments.
http://codereview.chromium.org/6894043/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/6894043/diff/1/src/hydrogen-instructions.h#newcode3800 src/hydrogen-instructions.h:3800: You should override CalculateInferredType to return Boolean. http://codereview.chromium.org/6894043/diff/1/src/ia32/lithium-ia32.cc File src/ia32/lithium-ia32.cc (right): http://codereview.chromium.org/6894043/diff/1/src/ia32/lithium-ia32.cc#newcode2209 src/ia32/lithium-ia32.cc:2209: LOperand* key = UseAtStart(instr->key()); Use UseOrConstantAtStart here. The same possibly also for other platforms. http://codereview.chromium.org/6894043/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
