I have uploaded a new version.
http://codereview.chromium.org/6874007/diff/5010/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6874007/diff/5010/src/arm/code-stubs-arm.cc#newcode833 src/arm/code-stubs-arm.cc:833: __ PrepareCallCFunction(4, scratch); // Two doubles are 4 arguments. Changed to PrepareCallCFunction(0, 2, scratch). http://codereview.chromium.org/6874007/diff/5010/src/arm/code-stubs-arm.cc#newcode834 src/arm/code-stubs-arm.cc:834: if (FLAG_hardfloat) { It is used from the TRBO stub, also with VFP3. http://codereview.chromium.org/6874007/diff/5010/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/6874007/diff/5010/src/arm/macro-assembler-arm.cc#newcode842 src/arm/macro-assembler-arm.cc:842: if (FLAG_hardfloat) { I replaced the vmov with the new MacroAssembler::Move. http://codereview.chromium.org/6874007/diff/5010/src/arm/macro-assembler-arm.cc#newcode2807 src/arm/macro-assembler-arm.cc:2807: int stack_passed_arguments = 0; I have added the comment. http://codereview.chromium.org/6874007/diff/5010/src/arm/macro-assembler-arm.cc#newcode2845 src/arm/macro-assembler-arm.cc:2845: if (FLAG_hardfloat) { Used Move. http://codereview.chromium.org/6874007/diff/5010/src/arm/macro-assembler-arm.cc#newcode2855 src/arm/macro-assembler-arm.cc:2855: if (FLAG_hardfloat) { On 2011/04/27 08:19:01, Søren Gjesse wrote:
Ditto.
Done. http://codereview.chromium.org/6874007/diff/5010/src/arm/macro-assembler-arm.cc#newcode2867 src/arm/macro-assembler-arm.cc:2867: if (FLAG_hardfloat) { On 2011/04/27 08:19:01, Søren Gjesse wrote:
Ditto (also mov -> Move).
Done. http://codereview.chromium.org/6874007/diff/5010/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/6874007/diff/5010/src/arm/simulator-arm.cc#newcode1738 src/arm/simulator-arm.cc:1738: if (::v8::internal::FLAG_trace_sim || !stack_aligned) { On 2011/04/27 08:19:01, Søren Gjesse wrote:
This printout of the arguments is not correct. It was also wrong
before, but now
you have more information to print it correctly.
Done. http://codereview.chromium.org/6874007/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
