LGTM with comment addressed. How about porting to x64 as well?
http://codereview.chromium.org/6816049/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6816049/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode798 src/ia32/lithium-codegen-ia32.cc:798: NearLabel done, remainder_eq_dividend, slow, do_subtraction, both_positive; Please set up Register variables for left as well: Register left = ToRegister(instr->InputAt(0)); And use it below instead of eax it more readable. http://codereview.chromium.org/6816049/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
