LGTM
http://codereview.chromium.org/6902112/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/6902112/diff/1/src/arm/lithium-codegen-arm.cc#newcode2495 src/arm/lithium-codegen-arm.cc:2495: key_is_constant ? Operand(constant_key * 4) : Operand(key, LSL, 2)); Can you break out the Operand into another line to avoid the line break, like you did in the ia32 and x64 versions? http://codereview.chromium.org/6902112/diff/1/src/arm/lithium-codegen-arm.cc#newcode2502 src/arm/lithium-codegen-arm.cc:2502: key_is_constant ? Operand(constant_key * 8) : Operand(key, LSL, 3)); Same here and below? http://codereview.chromium.org/6902112/diff/1/test/mjsunit/external-array.js File test/mjsunit/external-array.js (right): http://codereview.chromium.org/6902112/diff/1/test/mjsunit/external-array.js#newcode127 test/mjsunit/external-array.js:127: gc(); // Makes V8 forget about type information for test_func. I'm not sure you need this, since you call with different functions every time. Since you don't rely on it anywhere, AFAICT, it's a bit fragile, is it really needed? http://codereview.chromium.org/6902112/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
