LGTM
http://codereview.chromium.org/6901090/diff/1/SConstruct File SConstruct (right): http://codereview.chromium.org/6901090/diff/1/SConstruct#newcode343 SConstruct:343: }, As this is Linux only I think this should be either inside the os:linux section above or have a 'os:linux' inside. I think an os:linux here is the best choice, and makes adding more platforms most logical. http://codereview.chromium.org/6901090/diff/1/SConstruct#newcode488 SConstruct:488: 'CPPDEFINES': ['COMPRESS_STARTUP_DATA_BZ2'], Ditto for the LIBS part. http://codereview.chromium.org/6901090/diff/1/include/v8.h File include/v8.h (right): http://codereview.chromium.org/6901090/diff/1/include/v8.h#newcode2646 include/v8.h:2646: int id; Is this id actually required? http://codereview.chromium.org/6901090/diff/1/include/v8.h#newcode2649 include/v8.h:2649: int decompressed_size; Should the compression algorithm be exposed here (enum or string)? http://codereview.chromium.org/6901090/diff/1/include/v8.h#newcode2682 include/v8.h:2682: * The following 3 functions are to be used when V8 is built with with -> with the http://codereview.chromium.org/6901090/diff/1/samples/shell.cc File samples/shell.cc (right): http://codereview.chromium.org/6901090/diff/1/samples/shell.cc#newcode31 samples/shell.cc:31: #ifdef COMPRESS_STARTUP_DATA_BZ2 Should this support be added to D8 as well? The process sample? For the process sample maybe just add an #error. http://codereview.chromium.org/6901090/diff/1/src/mksnapshot.cc File src/mksnapshot.cc (right): http://codereview.chromium.org/6901090/diff/1/src/mksnapshot.cc#newcode130 src/mksnapshot.cc:130: bool Compress(Compressor* compressor) { ASSERT_EQ(-1, decompressed_size_)? http://codereview.chromium.org/6901090/diff/1/src/snapshot-empty.cc File src/snapshot-empty.cc (right): http://codereview.chromium.org/6901090/diff/1/src/snapshot-empty.cc#newcode36 src/snapshot-empty.cc:36: How about removing decompressed_ and instead adding raw_ (or something like that) to the input data, e.g. const byte Snapshot::raw_data_[] = { 0 }; const byte* Snapshot::data_ = NULL; http://codereview.chromium.org/6901090/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
