http://codereview.chromium.org/6880276/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/6880276/diff/1/src/hydrogen.cc#newcode4664 src/hydrogen.cc:4664: if (rep.Equals(Representation::Tagged())) { Done both. We generate the int32 representation. On 2011/04/29 08:56:22, fschneider wrote:
you can write
if (rep.IsTagged())
Until we support generic binary operations here, you could also just
generate an
integer32-add (like we did before)
http://codereview.chromium.org/6880276/diff/1/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/6880276/diff/1/src/type-info.cc#newcode342 src/type-info.cc:342: UNREACHABLE(); On 2011/04/29 08:56:22, fschneider wrote:
Maybe no need for UNREACHABLE() and the following return since there
is a
default-clause at the switch.
I think there is a MacOS compiler that can't handle the truth that our switch statement returns unconditionally. http://codereview.chromium.org/6880276/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
