[v8-dev] Re: Tiny refactoring - change compilation phase parameter for CopyForInlining from a boolean to an enum. (issue6913021)

[kmillikin]

LGTM.


http://codereview.chromium.org/6913021/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/6913021/diff/1/src/hydrogen.cc#newcode4108
src/hydrogen.cc:4108: HEnvironment* inner_env =
environment()->CopyForInlining(
I prefer breaking at an operator if possible, rather than the dangling
"(", which offends the lisper in me:

HEnvironment* inner_env =
    environment()->CopyForInlining(target,
                                   function,
                                   HEnvironment::HYDROGEN,
                                   undefined);

and it uses the same number of lines.

http://codereview.chromium.org/6913021/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev