http://codereview.chromium.org/6910022/diff/1/test/mjsunit/closures.js File test/mjsunit/closures.js (right):
http://codereview.chromium.org/6910022/diff/1/test/mjsunit/closures.js#newcode39 test/mjsunit/closures.js:39: %OptimizeFunctionOnNextCall(MyFunction) Maybe call the MyFunction function a couple of times to get type feedback before optimizing? http://codereview.chromium.org/6910022/diff/1/test/mjsunit/compiler/regress-closures-with-eval.js File test/mjsunit/compiler/regress-closures-with-eval.js (right): http://codereview.chromium.org/6910022/diff/1/test/mjsunit/compiler/regress-closures-with-eval.js#newcode55 test/mjsunit/compiler/regress-closures-with-eval.js:55: %OptimizeFunctionOnNextCall(withEval); Does this actually do anything? Will there be another call? http://codereview.chromium.org/6910022/diff/1/test/mjsunit/regress/regress-1099.js File test/mjsunit/regress/regress-1099.js (right): http://codereview.chromium.org/6910022/diff/1/test/mjsunit/regress/regress-1099.js#newcode51 test/mjsunit/regress/regress-1099.js:51: y("foo"); You should check the result here: assertTrue(y("foo")) http://codereview.chromium.org/6910022/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
